Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock objects' checkpoint methods no longer check static expectations. #64

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

asomers
Copy link
Owner

@asomers asomers commented Nov 2, 2019

This behavior is more useful where static and regular methods are both
used in the same test. The old behavior was a relic from release 0.3.0
and before, when static methods did not yet have Context objects of
their own.

This commit also fixes intermittent test failures in
mock_generic_struct_with_generic_static_method and
mock_struct_with_static_method. Those tests were failing because the
mock objects' checkpoints from one test were unexpectedly interfering
with static methods expectations' from other tests.

This behavior is more useful where static and regular methods are both
used in the same test.  The old behavior was a relic from release 0.3.0
and before, when static methods did not yet have Context objects of
their own.

This commit also fixes intermittent test failures in
mock_generic_struct_with_generic_static_method and
mock_struct_with_static_method.  Those tests were failing because the
mock objects' checkpoints from one test were unexpectedly interfering
with static methods expectations' from other tests.
@asomers asomers merged commit 63a0639 into master Nov 2, 2019
@asomers asomers deleted the static_checkpoints branch November 2, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant