mock generic methods returning non-static values #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why I added it in the first place, but it doesn't seem to be required now.
This is an internal refactor only; there is no functional change.
no functional change
It's now possible to mock generic methods whose return values' lifetimes are chosen by the caller. This is especially useful for methods that return std::future::Future. There are presently two restrictions: 1) static methods and bare functions of this type are not supported 2) The expectations' return values must be 'static. That can often be worked-around via an unsafe lifetime transmute. Hopefully both of those restrictions will be lifted in time. Fixes #76
asomers
added a commit
that referenced
this pull request
Dec 6, 2019
The regression was probably introduced by PR #86
asomers
added a commit
that referenced
this pull request
Dec 6, 2019
The regression was probably introduced by PR #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mock generic methods returning non-static values
It's now possible to mock generic methods whose return values' lifetimes are
chosen by the caller. This is especially useful for methods that return
std::future::Future.
There are presently two restrictions:
worked-around via an unsafe lifetime transmute.
Hopefully both of those restrictions will be lifted in time.
Fixes #76