Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement with_st to match non-Send arguments. #93

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Implement with_st to match non-Send arguments. #93

merged 3 commits into from
Dec 7, 2019

Conversation

Monnoroch
Copy link
Contributor

See #80.

asomers
asomers requested changes Dec 7, 2019
View reviewed changes
Copy link
Owner

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Aside from the few things I mentioned inline, it just needs a CHANGELOG entry.

mockall_derive/src/expectation.rs Outdated Show resolved Hide resolved
mockall/tests/automock_nonsend.rs Show resolved Hide resolved
@Monnoroch
Copy link
Contributor Author

Thanks Alan. I'm just not quite sure what to add to the changelog, it seems currently it's per-version and I don't know how to add an entry without knowing the next version number / date. Can you suggest something?

@asomers
Copy link
Owner

asomers commented Dec 7, 2019

I just started a new section in the CHANGELOG. If you rebase you'll get it.

@Monnoroch
Copy link
Contributor Author

All done!

@asomers asomers merged commit 459ed5c into asomers:master Dec 7, 2019
@asomers
Copy link
Owner

asomers commented Dec 7, 2019

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Monnoroch @asomers