Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: back out of vanity go module name #791

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Dec 16, 2024

aspect.build/cli is now a re-direct to docs.aspect.build which breaks the vanity go module name currently in use:

module aspect.build/cli

This PR backs out of the vanity naming and goes back to standard github.com/org/repo module name for the Aspect CLI.

BREAKING CHANGE

If you're depending on the aspect-cli repo in a downstream go module and want to update to the latest release, you'll need to update your go mod to depend on github.com/aspect-build/aspect-cli and update all corresponding import paths. The release that makes this change will be cut after this PR lands. The version is likely to be 2024.49.19 with the corresponding go module version of v1.202449.18.

Copy link

aspect-workflows bot commented Dec 16, 2024

Test

10 test targets passed

Targets
//bazel/buildeventstream:write_pb_go_test [k8-fastbuild]        2s
//integration_tests/aspect:configure_test [k8-fastbuild]        56s
//integration_tests/aspect:flags_test [k8-fastbuild]            2m 10s
//integration_tests/aspect:help_test [k8-fastbuild]             50s
//integration_tests/aspect:info_test [k8-fastbuild]             31s
//integration_tests/aspect:init_test [k8-fastbuild]             55s
//integration_tests/aspect:lint_test [k8-fastbuild]             1m 26s
//integration_tests/aspect:reenter_test [k8-fastbuild]          46s
//integration_tests/aspect:version_test [k8-fastbuild]          29s
//pkg/plugin/sdk/v1alpha4/proto:write_pb_go_test [k8-fastbuild] 72ms

Total test execution time was 8m 6s. 203 tests (95.3%) were fully cached saving 1m 21s.


Buildifier      Format

@gregmagolan gregmagolan force-pushed the backout_of_vanity_go_module_name branch from 6cf1557 to ef32c87 Compare December 16, 2024 01:00
@gregmagolan gregmagolan force-pushed the backout_of_vanity_go_module_name branch from ef32c87 to a62408c Compare December 16, 2024 01:36
@gregmagolan gregmagolan marked this pull request as ready for review December 16, 2024 01:52
@gregmagolan gregmagolan merged commit 4472f3c into main Dec 16, 2024
10 checks passed
@gregmagolan gregmagolan deleted the backout_of_vanity_go_module_name branch December 16, 2024 01:54
jbedard pushed a commit that referenced this pull request Jan 2, 2025
Updates copybara to account for
#791.

---

### Changes are visible to end-users: no

### Test plan

- Manual testing; please provide instructions so we can reproduce:

After this and #791
lands, run copybara sync out.

GitOrigin-RevId: 9234a139099662e5bcec7b464ec4dbc95586949e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant