refactor: make unresolved_symlinks_enabled attribute of js_binary man…

…datory (#1571)
aspect-build · May 6, 2024 · b9358e9 · b9358e9
1 parent 1382262
commit b9358e9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/docs/js_binary.md b/docs/js_binary.md
diff --git a/js/private/js_binary.bzl b/js/private/js_binary.bzl
@@ -267,8 +267,7 @@ _ATTRS = {
         attribute based on a `config_setting` rule.
         See /js/private/BUILD.bazel in rules_js for an example.
         """,
-        # TODO(2.0): make this mandatory so that downstream binary rules that inherit these attributes are required to set it
-        mandatory = False,
+        mandatory = True,
     ),
     "node_toolchain": attr.label(
         doc = """The Node.js toolchain to use for this target.