Document migration from pkg_web

[alexeagle]

I think it's some combo of "use some other packaging rule from rules_pkg" and #254. Maybe we can expose a macro that is a close approximation.

[ss185994]

is there an appropriate way to migrate from pkg_web in rules_nodejs to rules_js?

[alexeagle]

In migrations I've been doing, I simply removed pkg_web since the bundler produced a directory that could be directly deployed.

Can you give an example of how you're using it - what inputs you give it and what output you expect? I think rules_pkg should cover most use cases.

[ss185994]

this Is how it was setup with rules_nodejs

cmd/web/provider

container_image(
    name = "some-image",
    base = ":some-container",
    files = ["//path/to/web/iam"],
    ports = ["8080"],
    tags = ["manual"],
)

cmd/web/iam

pkg_web(
     name = "iam",
     srcs = [":build"], // result of react-scripts build
     substitutions = {"placeholder": "some_semver"},
     visibility = ["//visibility:public"],
 )

ive gotten the react-cra example more or less working would it be as easy as tossing the result of build to the container_image?

[alexeagle]

Yes exactly your pkg_web might not be doing anything extra there. Were you relying on it to stamp something? You can just compare the container layers before and after to convince yourself it produces the same result (or identify what needs to be changed to get it to match)