Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stamping #254

Closed
alexeagle opened this issue Jun 27, 2022 · 2 comments
Closed

Support stamping #254

alexeagle opened this issue Jun 27, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
Performance & Docs

Comments

@alexeagle
Copy link
Member

For example, update the version field in package.json before publishing.
@alexeagle alexeagle mentioned this issue Jul 5, 2022
Open
@alexeagle
Copy link
Member Author

probably blocked on bazel-contrib/bazel-lib#185 so we can use the same config_setting machinery

@gregmagolan
Copy link
Member

bazel-contrib/bazel-lib#185 landed

@gregmagolan gregmagolan added the enhancement New feature or request label Aug 3, 2022
@gregmagolan gregmagolan added this to the 1.1 milestone Aug 3, 2022
alexeagle added a commit that referenced this issue Aug 24, 2022
@alexeagle
feat: demonstrate stamping the version into package.json
f183e9e 
Fixes #254
jbedard pushed a commit to jbedard/rules_js that referenced this issue Aug 26, 2022
@alexeagle @jbedard
feat: demonstrate stamping the version into package.json (aspect-buil…
bc77791 
…d#402)

Fixes aspect-build#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Performance & Docs
Development

No branches or pull requests
2 participants
@alexeagle @gregmagolan