Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support pnpm lock v9 #1679

Merged
merged 1 commit into from
May 14, 2024
Merged

feat: support pnpm lock v9 #1679

merged 1 commit into from
May 14, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 23, 2024 •
edited
Loading

With the lockfile requiresBuild flag removed (pnpm/pnpm#7707) lifecycle hooks must now be manually specified using pnpm.onlyBuiltDependencies.

Type of change

  • New feature or functionality (change which adds functionality)

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested a review from gregmagolan April 23, 2024 09:45
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 23, 2024 •
edited
Loading

Test

All tests were cache hits

190 tests (100.0%) were fully cached saving 51s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 845ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 773ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 511ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

8 tests (100.0%) were fully cached saving 2s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 393ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

@jbedard jbedard changed the base branch from 2.x to main April 23, 2024 17:20
@jbedard jbedard force-pushed the pnpm-lock-v9 branch 2 times, most recently from a667e6f to d375061 Compare April 23, 2024 17:49
@jbedard jbedard changed the base branch from main to 2.x May 13, 2024 18:46
@jbedard jbedard force-pushed the pnpm-lock-v9 branch 2 times, most recently from 83d6957 to 9bf7831 Compare May 13, 2024 18:48
@jbedard jbedard force-pushed the pnpm-lock-v9 branch 3 times, most recently from 6e0ee58 to 8e3e2cb Compare May 14, 2024 19:52
@jbedard jbedard mentioned this pull request May 14, 2024
Closed
21 tasks
@jbedard jbedard force-pushed the pnpm-lock-v9 branch 4 times, most recently from c0b965b to 6401050 Compare May 14, 2024 21:32
gregmagolan
gregmagolan approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jbedard jbedard merged commit 3528874 into aspect-build:2.x May 14, 2024
97 checks passed
@jbedard jbedard deleted the pnpm-lock-v9 branch May 14, 2024 23:00
@jbedard jbedard mentioned this pull request May 14, 2024
Closed
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
feat: support pnpm lock v9 (aspect-build#1679)
a98e27c 
Close aspect-build#1652
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
feat: support pnpm lock v9 (#1679)
c82f68f 
Close #1652
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
feat: support pnpm lock v9 (#1679)
89f7c43 
Close #1652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan