Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align bzlmod and workspace patch_args default #1692

Merged
merged 1 commit into from
May 3, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented May 3, 2024

Align bzlmod and workspace default values.

Test plan

  • Manual testing; removing patch_args = [...] from tests such as e2e/npm_translate_lock_subdir_patch should fail the same with bzlmod and workspace.

Copy link

aspect-workflows bot commented May 3, 2024

Test

All tests were cache hits

211 tests (100.0%) were fully cached saving 42s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.


Test

e2e/gyp_no_install_script

All tests were cache hits

3 tests (100.0%) were fully cached saving 995ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 772ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 813ms.


Test

e2e/npm_translate_lock

All tests were cache hits

2 tests (100.0%) were fully cached saving 481ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 301ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 170ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 424ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

7 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 6s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 3s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 523ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 569ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 218ms.


Buildifier      Format

@jbedard jbedard enabled auto-merge (squash) May 3, 2024 03:38
@jbedard jbedard merged commit 15241c8 into aspect-build:main May 3, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants