-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove support for reloading lockfile on update #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
2 times, most recently
from
May 6, 2024 06:30
6ae502a
to
0624a77
Compare
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
from
May 6, 2024 06:39
0624a77
to
89fbd80
Compare
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
from
May 6, 2024 17:27
89fbd80
to
d1fe919
Compare
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
2 times, most recently
from
May 6, 2024 19:23
00a9a44
to
67b6ab2
Compare
gregmagolan
reviewed
May 7, 2024
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
from
May 7, 2024 00:09
67b6ab2
to
60e1311
Compare
gregmagolan
reviewed
May 7, 2024
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
2 times, most recently
from
May 7, 2024 00:25
def5af0
to
5fc719e
Compare
gregmagolan
reviewed
May 7, 2024
gregmagolan
reviewed
May 7, 2024
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
from
May 7, 2024 00:30
5fc719e
to
4589956
Compare
jbedard
force-pushed
the
2.x-pnpm-no-reload
branch
from
May 7, 2024 00:40
4589956
to
b7919c1
Compare
gregmagolan
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
gregmagolan
pushed a commit
that referenced
this pull request
May 7, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 7, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 7, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 7, 2024
jbedard
added a commit
that referenced
this pull request
May 8, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 10, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 10, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 13, 2024
jbedard
added a commit
to jbedard/rules_js
that referenced
this pull request
May 14, 2024
jbedard
added a commit
that referenced
this pull request
May 14, 2024
jbedard
added a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 20, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reloading isn't supported with bzlmod so we should not support it with non-bzlmod just to make things consistent.
Close #1445
Changes are visible to end-users: yes/no
When
npm_translate_lock(update_pnpm_lock)
updates the lockfile it will exit with a non-0 exit code and must be rerun with the updated lockfile.Test plan