fix: fix issue with bzlmod toolchain registration by bumping minimum rules_nodejs to 6.1.2 #1780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1530 by bringing in the rules_nodejs fix bazel-contrib/rules_nodejs#3750 which was released with rules_nodejs v6.1.2.
Changes are visible to end-users: yes
Minimum Aspect bazel-lib version is now 6.1.2
Test plan
On darwin, where the issue #1530 occurs, ran
bazel test //src:image_test
and confirmed it currently fails onmain
and passes with this fix.Without fix:
With fix test passes.