Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with bzlmod toolchain registration by bumping minimum rules_nodejs to 6.1.2 #1780

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jun 6, 2024

Fixes #1530 by bringing in the rules_nodejs fix bazel-contrib/rules_nodejs#3750 which was released with rules_nodejs v6.1.2.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Minimum Aspect bazel-lib version is now 6.1.2

Test plan

  • Covered by existing test cases
  • Manual testing; please provide instructions so we can reproduce:

On darwin, where the issue #1530 occurs, ran bazel test //src:image_test and confirmed it currently fails on main and passes with this fix.

Without fix:

--- FAIL
duration: 180.569083ms
stderr: /app/src/bin.runfiles/_main/src/bin_node_bin/node: line 5: /app/src/bin.runfiles/_main/../rules_nodejs~~node~nodejs_darwin_arm64/bin/nodejs/bin/node: cannot execute binary file: Exec format error

With fix test passes.

@gregmagolan gregmagolan requested review from thesayyn and jbedard June 6, 2024 19:11
Copy link

aspect-workflows bot commented Jun 6, 2024

Test

All tests were cache hits

193 tests (100.0%) were fully cached saving 53s.


Test

e2e/bzlmod

2 test targets passed

Targets
//:jasmine_test [k8-fastbuild]125ms
//:test [k8-fastbuild]268ms

Total test execution time was 393ms. 2 tests (50.0%) were fully cached saving 93ms.


Test

e2e/gyp_no_install_script

1 test target passed

Targets
//:test [k8-fastbuild]260ms

Total test execution time was 260ms. 1 test (50.0%) was fully cached saving 297ms.


Test

e2e/js_image_oci

1 test target passed

Targets
//src:image_test [k8-fastbuild]7s

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

1 test target passed

Targets
//subdir:test [k8-fastbuild]251ms

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

1 test target passed

Targets
//:test [k8-fastbuild]566ms

Test

e2e/pnpm_lockfiles

8 test targets passed

Targets
//v54:aliases-test [k8-fastbuild]237ms
//v54:patch-test [k8-fastbuild]297ms
//v60:aliases-test [k8-fastbuild]286ms
//v60:patch-test [k8-fastbuild]498ms
//v61:aliases-test [k8-fastbuild]210ms
//v61:patch-test [k8-fastbuild]454ms
//v90:aliases-test [k8-fastbuild]218ms
//v90:patch-test [k8-fastbuild]381ms

Total test execution time was 3s. 20 tests (71.4%) were fully cached saving 6s.


Test

e2e/pnpm_workspace

6 test targets passed

Targets
//:node_test [k8-fastbuild]1s
//app/a:aspect_test_a_bin_test [k8-fastbuild]203ms
//app/a:test [k8-fastbuild]282ms
//app/b:test [k8-fastbuild]186ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]237ms
//app/c:test [k8-fastbuild]260ms

Total test execution time was 3s. 2 tests (25.0%) were fully cached saving 545ms.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

1 test target passed

Targets
//:test [k8-fastbuild]195ms

Total test execution time was 195ms. 1 test (50.0%) was fully cached saving 258ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.


Buildifier      Format

@gregmagolan gregmagolan requested a review from alexeagle June 6, 2024 19:17
@gregmagolan gregmagolan changed the title fix: fix issue with bzlmod toolchain registration with minimum bump to rules_nodejs 6.1.2 fix: fix issue with bzlmod toolchain registration by bumping minimum rules_nodejs to 6.1.2 Jun 6, 2024
@alexeagle alexeagle enabled auto-merge (squash) June 6, 2024 19:20
@alexeagle alexeagle merged commit bc87775 into main Jun 6, 2024
107 checks passed
@alexeagle alexeagle deleted the bump_min_rules_nodejs branch June 6, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: js_image_layer is broken with bzlmod
2 participants