Skip to content

Commit

Permalink
docs(eslint): upgrade ts_project macro notes (#411)
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard authored Oct 11, 2024
1 parent 559ed12 commit 0267f89
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions docs/eslint.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions lint/eslint.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ eslint = lint_eslint_aspect(
)
```
### With ts_project
### With ts_project <=3.2.0
Note, when used with `ts_project` and a custom `transpiler`,
the macro expands to several targets,
see https://github.com/aspect-build/rules_ts/blob/main/docs/transpiler.md#macro-expansion.
Prior to [commit 5e25e91]https://github.com/aspect-build/rules_ts/commit/5e25e91420947e3a81938d8eb076803e5cf51fe2)
the rule produced by the `ts_project` macro and a custom `transpiler` expanded the macro to
multiple targets, including changing the default target to `js_library`.
Since you want to lint the original TypeScript source files, the `ts_project` rule produced
by the macro is the one you want to lint, so when used with an `eslint_test` you should use
Expand Down

0 comments on commit 0267f89

Please sign in to comment.