-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Undeclared dependence on bazel-lib 2.7.7 #351
Comments
Now it matches the version in MODULE.bazel. Fixes #351
I guess you're using WORKSPACE and not bzlmod, since the MODULE.bazel file in this repo already has a minimum of bazel-lib 2.5.0. See #354 |
I don't think so, the reproduction branch I linked above doesn't even have a WORKSPACE file, only MODULE.bazel: |
Also note, the required dependency is >2.5.0, 2.5.0 is in the MODULE.bazel file and it doesn't work. |
@alexeagle I'm not sure this should be closed. Did you take a look at the branch that is reproducing this issue? It is using bzlmod. The issue isn't with not having 2.5.0, 2.5.0 is not enough. 2.7.7 makes it work. Note: rules_lint contains an override to 2.7.7. Sorry I haven't done a good job explaining the issue. The reproduction steps above are probably the best way to demonstrate the problem. |
We used a single_version_override locally which makes it hard to repro what users see. Note that the example was already on 2.7.7, this just lines them up. Fixes #351
What happened?
The
clang-tidy
aspect contains an undeclared dependency onbazel-lib
2.7.7 (or at least one >2.5.0). If you pare theexample
module down to just theclang-tidy
relevant code, you technically don't need to depend onbazel-lib
directly, but when you remove this dependency the version inrules_lint
(2.5.0) is insufficient. If you change the dependency inrules_lint
to 2.7.7, things work as expected.Version
Development (host) and target OS/architectures: linux x86
Output of
bazel --version
: bazel 7.2.1Language(s) and/or frameworks involved: C/C++ clang-tidy
How to reproduce
Any other information?
No response
The text was updated successfully, but these errors were encountered: