Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tfsec security linter #326

Closed
wants to merge 1 commit into from
Closed

feat: add tfsec security linter #326

wants to merge 1 commit into from

Conversation

mattem
Copy link
Member

@mattem mattem commented Jul 10, 2024

Adds the tfsec Terraform security linter.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Add the tfsec Terraform security linter.

Test plan

  • New test cases added

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
example/src/BUILD.bazel Show resolved Hide resolved
example/.aspect/cli/config.yaml Show resolved Hide resolved
example/src/hello.tf Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to example/test/lint_test.bats please so we have some automated test coverage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I run this? I don't see any bats_test targets in example/test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't run them with Bazel right now, was too difficult. There's an integration-test job in the .github/workflows/ci.yaml.

I can add the test as a followup if you want

lint/tfsec.bzl Show resolved Hide resolved
@mattem
Copy link
Member Author

mattem commented Jul 11, 2024

Closing for the moment

@mattem mattem closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants