Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out 'external' sources from linting #358

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: filter out 'external' sources from linting #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lint/private/lint_aspect.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def filter_srcs(rule):
if "lint-genfiles" in rule.attr.tags:
return rule.files.srcs
else:
return [s for s in rule.files.srcs if s.is_source]
return [s for s in rule.files.srcs if s.is_source and s.owner.workspace_name == ""]

def noop_lint_action(ctx, outputs):
"""Action that creates expected outputs when no files are provided to a lint action.
Expand Down
Loading