Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include stylelint config deps (#394) #395

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

sallustfire
Copy link
Contributor

If the stylelint config is declared via js_library and has a dependency on other sources or npm packages, these dependencies are now included in the linting action.


Changes are visible to end-users: yes/no

yes, this fixes a bug in what is a standard pattern

Test plan

  • The existing test case is extended to have a dependency on a npm package in the config

If the stylelint config is declared via js_library and has a dependency on
other sources or npm packages, these dependencies are now included in the
linting action.
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! nice job adding the missing example usage as regression test

@alexeagle alexeagle merged commit 2d216da into aspect-build:main Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants