Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: start testing on Bazel 8" #404

Merged
merged 1 commit into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,18 @@ concurrency:

jobs:
bazel-test:
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@bazel8
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@v6
with:
folders: '[".", "example"]'
# Don't try for Windows support yet.
exclude_windows: true
# Root module is bzlmod-only and uses newer stardoc that requires Bazel 7.
# Example uses incompatible_enable_proto_toolchain_resolution
exclude: |
[
{"bzlmodEnabled": false, "folder": "."},
{"bazelversion": "6.4.0"}
]

integration-test:
runs-on: ubuntu-latest
Expand Down
1 change: 0 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ bazel_dep(name = "aspect_bazel_lib", version = "2.7.7")
# Minimum version needs 'chore: bump bazel-lib to 2.0 by @alexeagle in #1311'
# to allow users on bazel-lib 2.0
bazel_dep(name = "aspect_rules_js", version = "1.40.0")
bazel_dep(name = "bazel_features", version = "1.18.0")
bazel_dep(name = "bazel_skylib", version = "1.4.2")
bazel_dep(name = "platforms", version = "0.0.7")
bazel_dep(name = "rules_multirun", version = "0.9.0")
Expand Down
3 changes: 0 additions & 3 deletions docs/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# This load statement must be in the docs/ package rather than anything users depend on
# so that the dependency on stardoc doesn't leak to them.
load("@aspect_bazel_lib//lib:docs.bzl", "stardoc_with_diff_test", "update_docs")
load("@bazel_features//private:util.bzl", "lt")

stardoc_with_diff_test(
name = "lint_test",
Expand Down Expand Up @@ -36,8 +35,6 @@ stardoc_with_diff_test(
stardoc_with_diff_test(
name = "format",
bzl_library_target = "//format:defs",
# See https://github.com/bazel-contrib/bazel_features/pull/75
target_compatible_with = ["@platforms//:incompatible"] if lt("8.0.0-pre.20240911.1") else [],
)

stardoc_with_diff_test(
Expand Down
4 changes: 2 additions & 2 deletions docs/format.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading