-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use original interpreter path as 'home' value in pyvenv.cfg #226
Conversation
Thanks for making this fix, @mattem! This patch absolutely fixed my Python 3.11 woes. @alexeagle Any chance of you doing a release in the near future? I've pinned our usage of aspect_rules_py to this commit in the meantime, but I'd love to get back to using a I appreciate you both! Thank you. 🙇 |
@shinypb sure I'll push a tag right now. |
@alexeagle Howdy! That never made it to the central registry 🤔 It's still showing 0.4.0 as the latest release: |
Thanks for fixing this. If I'm not mistaken, rules_py/py/private/venv/venv.tmpl.sh Line 142 in e5c2112
I tried using: py_venv(
name = "my_venv",
deps = ["//src:my_lib"],
) to create a venv under Also the content of
I have dependencies of |
…env.cfg This is a follow-up of aspect-build#226 to fix another place.
I tried proposing a small fix for the pyvenv.cfg in #228 . Unfortunately I will not be able to sign CLA personally, so please feel free to discard the PR and get the fix in. Thank you. |
This is a follow-up of #226 to fix another place.
This is a follow-up of #226 to fix another place.
Use the original (source) interpreters bin path as the 'home' value in the generated
pyvenv.cfg
file.Closes #159
Type of change
For changes visible to end-users
Ensure correct
home
pathing is used when generating the venv.Test plan
Updated e2e smoke to use py3.11