Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a way for individual ts_project targets to reserve extr… #569

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

alexeagle
Copy link
Member

…a RAM

Some targets are globs of a large amount of code. By default Bazel allocates only 250MB See bazelbuild/bazel@d7f0724#diff-139b184febb86269f1ceee705bde7274e2efcccaa3f435a8c6cb2f1f0854ce46R96


Type of change

  • New feature or functionality (change which adds functionality)

For changes visible to end-users

  • Relevant documentation has been updated

Test plan

  • New test cases added

ts/private/ts_lib.bzl Outdated Show resolved Hide resolved
@alexeagle
Copy link
Member Author

Note, this isn't urgent for @DavidZbarsky-at as it's already patched there, so I'll try to land the principled thing in bazel-lib first (many of our rulesets should expose this)

@alexeagle
Copy link
Member Author

Landed bazel-contrib/bazel-lib#792

This ought to depend on bazel-lib 2.0 now, but we have the usual problem that it's a breaking change. Maybe we can have a separate entry point for ts_project_with_resource_set. Or just wait for rules_ts 3.0? Or give up on our adherence to semver and just require bazel-lib 2.0 in a 2.x release of rules_ts.

@alexeagle alexeagle added this to the 3.0 milestone Apr 8, 2024
@gregmagolan gregmagolan mentioned this pull request May 6, 2024
21 tasks
@gregmagolan
Copy link
Member

@alexeagle
Copy link
Member Author

now that main targets rules_ts 3.x and is guaranteed to have bazel-lib 2.x, I'm unblocked to rely on the new resource_sets helper :)

Copy link

aspect-workflows bot commented Jul 10, 2024

Test

1 test target passed

Targets
//docs:update_0_test [k8-fastbuild] 30ms

Total test execution time was 30ms. 80 tests (98.8%) were fully cached saving 12s.


Buildifier      Format

@alexeagle alexeagle merged commit acd9f4f into main Jul 10, 2024
23 checks passed
@alexeagle alexeagle deleted the resource_set branch July 10, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants