-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
Previously, the async errors would make the tests time out and errors not to be associated with the tests they occured in.
Problem solved with linting! Thanks, @blumamir! |
Great :) I see now in the issue that it might be fixed in version 6 of husky, which we can test and verify one day |
opened an issue for that: #152 |
}; | ||
|
||
export const createServerInstance = (server?: http.Server) => { | ||
if (version && /^2\./.test(version)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as current support is only for version 2, we are expecting this if
to always be truthy, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current support is for v3 and v4, so the opposite - we currently expect it to be always falsy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right :)
LGTM |
LGTM |
The oldest current version supported is from 8 months ago. I'd like to support at least v2(2.0.0 released in 2017, latest 2.x in 2021). However, the initialization is a bit different for that. This PR prepares a few of the things without actually adding support for v2 or changing any of the behaviour to make the next PR more concise and easier to follow.
Check the commits for details, but:
Look out for any linting/formatting inconsistencies, because I didn't find a way to automatically apply those(I see GHA job for prettier but running default prettier gave me tons of markdown changes as well - just isolate to
ts
files?).