This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
feat: amqplib (RabbitMQ) instrumentation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- opentelemetry-instrumentation-mongoose@0.2.3 - opentelemetry-instrumentation-neo4j@0.2.3
…ext-js into instrumentation-amqplib
YanivD
approved these changes
Mar 12, 2021
packages/instrumentation-amqplib/test/amqplib-callbacks.spec.ts
Outdated
Show resolved
Hide resolved
| const msgPayload = 'payload from test'; | ||
| const queueName = 'queue-name-from-unittest'; | ||
|
|
||
| describe('amqplib instrumentation promise model', function () { |
There was a problem hiding this comment.
I suggest to add another test that confirms instrumentation.disable() works well
- create publish.
- disable instrumentation
- create publish
- confirm only 1 span created
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
nirsky
reviewed
Mar 14, 2021
added 5 commits
March 15, 2021 10:24
…ext-js into instrumentation-amqplib
added 6 commits
March 15, 2021 13:25
nirsky
approved these changes
Mar 15, 2021
added 2 commits
March 15, 2021 15:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.