Update test projects to latest stable xUnit.net packages and nuget.exe
#29
Conversation
- #11 (4 of 4 or so) - newer version of `xunit.abstractions` exists (2.0.1) but it "is not compatible with 'xunit.extensibility.core 2.1.0 constraint: xunit.abstractions (= 2.0.0)'" - add xunit.runner.msbuild package to central packages.config - need this package to execute tests after upgrade to xUnit.net 2.1.0 - need recent Beta to pick up PR xunit/xunit#807; MSBuild crashes otherwise - for this part, do not make *.csproj changes that NuGet attempts; update our `WebStack.xunit.targets` instead - use latest `xunit.exe` because Beta xunit.runner.msbuild package needs at least 2.12 - old 2.7 minimum version, 2.8 that is at https://nuget.org/nuget.exe, and 2.12 are also all old
- continue to expose required xUnit.net classes in `Microsoft.TestCommon` namespace - adjust to `sealed` classes, namespace moves, et cetera - do not use removed `Assert.ThrowsDelegate` and `Assert.ThrowsDelegateWithReturn` types - can't use these types with underlying `Assert` using `Action` and `Func<object>` - remove `StringAssertions` since those assertions are now in xUnit.net nits - remove `Console.WriteLine()` from a test - use new `Assert.Matches()` in tests checking exception messages that contain a Moq proxy type name
- do not use `GlobalFacebookConfiguration` - group tests that read / write `static`s (`ScopeStorage` and `ViewEngines`) together - one `[Xunit.Collection]` for all readers and writers - won't run in parallel, avoiding reads while writers have messed up the state - `IDisposable` for all test classes that don't already reliably clean up their writes - enable the subset of above tests that were disabled due to previous use of `static`s
- tests sometimes hang with loads of threads stuck in `BackgroundParser.MainThreadState.GetParcel()`
|
Hi @dougbu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| using Microsoft.TestCommon; | ||
| using Moq; | ||
|
|
||
| namespace Microsoft.Web.Helpers.Test | ||
| { | ||
| public class FacebookTest | ||
| [Xunit.Collection("Uses ScopeStorage or ViewEngines.Engines")] |
There was a problem hiding this comment.
Unfortunately CollectionAttribute is found elsewhere in xUnit.net using the exact type and, worse, it's sealed. Can't expose anything like it in the Microsoft.TestCommon namespace. Also can't add a using Xunit without causing many ambiguous references.
|
As usual, it's probably easier to review the individual commits. The middle commits are even easier if you ignore whitespace changes, adding |
|
Thanks @rynowak! Also many thanks to @pranavkm @NTaylorMullen and @ajaybhargavb for their help with the other parts of this massive 4-part change. |
|
Oops, I meant just "the other parts of this one". |
| } | ||
| } | ||
|
|
||
| return string.Join(Environment.NewLine, results.ToArray()); |
There was a problem hiding this comment.
nit: ToArray isn't needed here, it can work on IEnumerable<>
|
|
| using (var mockResult = new MockAsyncResult()) | ||
| { | ||
| // Act | ||
| ActionResult result = BeginInvokeActionMethodWithFiltersTester(() => mockResult, action, checkBegin: true, checkEnd: true, filters: actionFilter); |
There was a problem hiding this comment.
Getting rid of the "helper" overload turned out to be a mistake. I'll instead add an IAsyncResult parameter to the old overload. That'll reduce the amount of churn in this class.
|
🆙📅 @rynowak I'd appreciate your eyes on the new commit. |
dougbu
force-pushed
the
dougbu/xunit.latest.11
branch
from
ccb5d3e
to
c2b1f69
Compare
|
🆙📅 replaced last commit to reduce |
- reduce work done within inner loop - add messages for `Exception`s this class `throw`s - release acquired `Mutex`es - reduce timeout for acquiring global `Mutex`
- need xUnit.net AppDomain support in console runs but not in VS runs - setting in `WebStack.xunit.targets` overrides `xunit.runner.json` default - somewhat avoids issues such as xunit/xunit#353 and xunit/xunit#947 - pre-enumerating `[Theory]`s also slows down test discovery and execution - remains a good idea to leave the test execution engine running
|
🆙📅 added a couple more workarounds and perf improvements |
|
|
xunit.abstractionsexists (2.0.1) but it"is not compatible with 'xunit.extensibility.core 2.1.0 constraint: xunit.abstractions (= 2.0.0)'"
WebStack.xunit.targetsinsteadxunit.exebecause Beta xunit.runner.msbuild package needs at least 2.12See details of the following in the individual commits:
staticstateManualResetEventSlims orThreads waiting on them