This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Fixed exception messages for server variable parsing #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscrepancies between the two server variable parsing methods
| case "TIME": | ||
| return new DateTimeSegment(variable); | ||
| return new DateTimeSegment(serverVariable); | ||
| case "API_VERSION": | ||
| throw new NotSupportedException(); |
There was a problem hiding this comment.
Add a message for this one
natemcmaster
approved these changes
Oct 21, 2016
| @@ -55,7 +55,7 @@ public static PatternSegment FindServerVariable(string serverVariable) | |||
| case "REQUEST_URI": | |||
| return new UrlSegment(); | |||
| default: | |||
| throw new FormatException("Unrecognized server variable"); | |||
| throw new FormatException(Resources.FormatError_InputParserUnrecognizedParameter(serverVariable, context.Index)); | |||
There was a problem hiding this comment.
The code has become inconsistent on strings vs resources. We should add an issue to clean this up. (You don't need to add to this PR.)
There was a problem hiding this comment.
Okay, I logged #153
Tratcher
approved these changes
Oct 21, 2016
|
@muratg Is this okay to merge to dev, or should we wait? |
|
@mikaelm12 yeah, it should be OK to merge to dev. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing here is that some of the exception messages for the server variable parsing was incorrect as pointed out in #143. I also did some refactoring to make the server variable parsing for IIS Url rewrite and Apache mod rewrite a little more similar.
Not urgent, just thought I'd open the pr.
@BrennanConroy @Tratcher @natemcmaster @muratg