Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TieredPGO_InstrumentOnlyHotCode=0 to tier0 jobs #1765

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

EgorBo
Copy link
Contributor

@EgorBo EgorBo commented Oct 31, 2022

We recently merged dotnet/runtime#70941 to runtime
It means that pgo=tier0-instrumented job no longer measures instrumented code and TieredPGO_InstrumentOnlyHotCode=0 should be added to bring it back.

image

cc @sebastienros

@sebastienros sebastienros merged commit 496944a into aspnet:main Oct 31, 2022
@sebastienros
Copy link
Member

Lesson: we should keep setting the values even when they are the default.

@EgorBo
Copy link
Contributor Author

EgorBo commented Oct 31, 2022

Yep, but in this case TieredPGO_InstrumentOnlyHotCode=0 is a new thing - it didn't exist previously 🙂

@EgorBo EgorBo deleted the fix-tier0 branch October 31, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants