Restore source dependencies feature (#185) #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarblum
requested review from
halter73,
davidfowl,
natemcmaster and
mikeharder
cesarblum
commented
Feb 15, 2017
src/BenchmarksServer/Startup.cs
Outdated
|
|
||
| // Restore in each dir | ||
| foreach (var dir in dirs) | ||
| ProcessUtil.Run("dotnet", "restore /p:VersionSuffix=zzzzz-99999", workingDirectory: Path.Combine(path, benchmarksDir)); |
There was a problem hiding this comment.
The version suffix needs to be higher than whatever package versions we have in our feed. Hence this thing. I tried coming up with something whimsical but decided to go with this boring suffix 😛
There was a problem hiding this comment.
I think this deserves a comment.
mikeharder
approved these changes
Feb 15, 2017
|
It makes me a bit uncomfortable to override the |
halter73
approved these changes
Feb 15, 2017
src/BenchmarksServer/Startup.cs
Outdated
|
|
||
| // Restore in each dir | ||
| foreach (var dir in dirs) | ||
| ProcessUtil.Run("dotnet", "restore /p:VersionSuffix=zzzzz-99999", workingDirectory: Path.Combine(path, benchmarksDir)); |
There was a problem hiding this comment.
I think this deserves a comment.
cesarblum
force-pushed
the
cesarbs/185-alt
branch
from
9dc67ab to
9a805fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better alternative to #188. Uses
ProjectReferenceand does not require intermediate builds.Thanks @dsplaisted for pointing out that
restore /p:VersionSuffix=does the trick! 😄#185