Include portable .pdb files in regular nupkgs when Internal.AspNetCore.Sdk is used #568
Conversation
…pNetCore.Sdk is used
| </PropertyGroup> | ||
|
|
||
| <Target Name="_EnsurePdbsInNupkgArePortable" BeforeTargets="GenerateNuspec" Condition=" '$(IsPackable)' != 'false' "> | ||
| <Error Text="Symbols included in a nupkg package should be portable. Set DebugType=portable or IncludeSymbols=false." |
There was a problem hiding this comment.
Set DebugType=portable orand IncludeSymbols=false
There was a problem hiding this comment.
Maybe I should clarify. What I meant here was Fix by setting DebugType=portable or disable inclusion of symbols by setting IncludeSymbols=false
There was a problem hiding this comment.
Maybe split this in to two?
Symbols were set to be included but the project was built using
DebugType = full. SetDebugType = portableto include portable pdbs required for symbol publishing or stop including symbols by settingIncludeSymbols=false
There was a problem hiding this comment.
that's much better. I'll update the error.
|
|
||
| <Target Name="_EnsurePdbsInNupkgArePortable" BeforeTargets="GenerateNuspec" Condition=" '$(IsPackable)' != 'false' "> | ||
| <Error Text="Symbols included in a nupkg package should be portable. Set DebugType=portable or IncludeSymbols=false." | ||
| Condition=" '$(DebugType)' != 'portable' AND '$(IncludeSymbols)' == 'true' " /> |
There was a problem hiding this comment.
Btw, the last I looked, symbols for Razor's net46 binaries are full. Can you verify this works for the repo?
There was a problem hiding this comment.
Why are they full? Don't we need portable for these to work for x-plat?
There was a problem hiding this comment.
I'm not entirely sure. @NTaylorMullen might know more.
There was a problem hiding this comment.
Looks like it's due to this, right? aspnet/Razor#1548 If we need full for VS, let's still produce portable by default. We can convert portable symbols to full in our VS publishing steps. I believe @muratg knows how to do that.
There was a problem hiding this comment.
Ahh, yeah. Completely forgot I made that change 👍
Allows adding .pdb files in the .nupkg for aspnetcore packages that end up on NuGet.org.
cref aspnet/Universe#131
cc @Eilon @JunTaoLuo @ctaggart