Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bill of materials tasks #595

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

natemcmaster
Copy link
Contributor

In the end, this build manifest output didn't prove to be useful enough to keep. The .NET Core engineering team created something similar for the
Product Construction Plan which was sufficient, so we decided to eliminate this altogether in favor of consolidating build infrastructure.

Resolves aspnet/Universe#679

cc @muratg

In the end, this build manifest output didn't prove to be useful enough to keep.
The .NET Core engineering team created something similar for  the
Product Construction Plan which was sufficient,
so we decided to eliminate this altogether
in favor of consolidating build infrastructure.
@pranavkm
Copy link
Contributor

pranavkm commented Mar 1, 2018

Guessing this is unused in Universe? 🚢 🇮🇹

@natemcmaster
Copy link
Contributor Author

Yeah, Universe set <GenerateBillOfMaterials>false</GenerateBillOfMaterials> from the beginning because we didn't finish implementing a bill of materials merge feature to combine manifests from all repo builds.

Copy link

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the missing pieces in prodcon manifest that ours used to have?

@natemcmaster
Copy link
Contributor Author

What are the missing pieces in prodcon manifest that ours used to have?

We never fully finished producing the bill of materials for a universe build....so nothing.

@natemcmaster natemcmaster merged commit 599e691 into aspnet:dev Mar 1, 2018
@natemcmaster natemcmaster deleted the rm-bom branch March 1, 2018 17:53
pakrym added a commit that referenced this pull request Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants