Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable package analysis in Internal.AspNetCore.Sdk #598

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Disable package analysis in Internal.AspNetCore.Sdk #598

merged 1 commit into from
Mar 7, 2018

Conversation

natemcmaster
Copy link
Contributor

It provides little value for us and the warnings have almost never been useful.

@natemcmaster
Disable package analysis in Internal.AspNetCore.Sdk
7e975ec 
It provides little value for us and the warnings have almost never been useful
@natemcmaster natemcmaster requested a review from pranavkm March 7, 2018 00:42
Eilon
Eilon approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<NotSignedOff>false</NotSignedOff>

@natemcmaster natemcmaster merged commit e9aafe2 into dev Mar 7, 2018
@natemcmaster natemcmaster deleted the namc/pkg-anlys branch March 7, 2018 07:57
pakrym added a commit that referenced this pull request Mar 8, 2018
@pakrym
Revert "Disable package analysis in Internal.AspNetCore.Sdk (#598)"
b26512f 
This reverts commit e9aafe2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eilon Eilon Eilon approved these changes

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemcmaster @Eilon