Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Add MemoryDistributedCacheOptions to enables configuration of the MemoryCache used #329

Closed
javiercn opened this issue Jul 3, 2017 · 2 comments
Closed

Add MemoryDistributedCacheOptions to enables configuration of the MemoryCache used #329

javiercn opened this issue Jul 3, 2017 · 2 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
2.0.0

Comments

@javiercn
Copy link
Member

javiercn commented Jul 3, 2017

https://github.com/aspnet/Caching/blob/dev/src/Microsoft.Extensions.Caching.Memory/MemoryCacheServiceCollectionExtensions.cs#L83

It makes it impossible to configure it.
@muratg
Copy link

muratg commented Jul 3, 2017

cc @davidfowl

@Tratcher Tratcher mentioned this issue Jul 5, 2017
Merged
5 tasks
@JunTaoLuo JunTaoLuo mentioned this issue Jul 5, 2017
Closed
@JunTaoLuo JunTaoLuo self-assigned this Jul 7, 2017
@JunTaoLuo JunTaoLuo added this to the 2.0.0 milestone Jul 7, 2017
@JunTaoLuo JunTaoLuo changed the title AddDistributedMemoryCache should not create its own MemoryCache instance Add MemoryDistributedCacheOptions to enables configuration of the MemoryCache used Jul 7, 2017
@JunTaoLuo
Copy link
Contributor

POR:

  • The MemoryDistributedCacheOptions should mirror the options available on MemoryCacheOptions
  • A default size of 200 MB will be set
  • The MemoryDistributedCache will by default create a new MemoryCache using the configured MemoryDistributedCacheOptions.

This was referenced Jul 7, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@muratg @JunTaoLuo @javiercn