Add MemoryDistributedCacheOptions and use it to configure MemoryCache used by MemoryDistributedCache #336
Conversation
| /// The <see cref="Action{MemoryDistributedCacheOptions}"/> to configure the provided <see cref="MemoryDistributedCacheOptions"/>. | ||
| /// </param> | ||
| /// <returns>The <see cref="IServiceCollection"/> so that additional calls can be chained.</returns> | ||
| public static IServiceCollection AddDistributedMemoryCache(this IServiceCollection services, Action<MemoryDistributedCacheOptions> setupAction) |
There was a problem hiding this comment.
AddDistributedMemoryCache vs MemoryDistributedCache we should normalize the naming here. Pick one and go with it.
There was a problem hiding this comment.
This is ok. Both names are already used publicly, you can't change it without breaking APIs.
There was a problem hiding this comment.
I think it's good to keep things consistent and if we are going to break things, we should break them in 2.0
There was a problem hiding this comment.
Well we are branching on Monday now so... it's functionally yesterday.
… used by MemoryDistributedCache
JunTaoLuo
force-pushed
the
johluo/mem-dis-cache-updates
branch
from
bf34135 to
5e73a85
Compare
| /// The <see cref="Action{MemoryDistributedCacheOptions}"/> to configure the provided <see cref="MemoryDistributedCacheOptions"/>. | ||
| /// </param> | ||
| /// <returns>The <see cref="IServiceCollection"/> so that additional calls can be chained.</returns> | ||
| public static IServiceCollection AddDistributedMemoryCache(this IServiceCollection services, Action<MemoryDistributedCacheOptions> setupAction) |
There was a problem hiding this comment.
This is ok. Both names are already used publicly, you can't change it without breaking APIs.
|
I'm going to merge as is for now, if we want to change the naming, we can do it afterwards. |
|
merged in 5e73a85 |
Needs rebase once #332 goes in.
Addresse #329