Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Implement IOptions accessor for MemoryDistributedCacheOptions #337

Closed
wants to merge 1 commit into from

Conversation

JunTaoLuo
Copy link
Contributor

Something we should have done in #336

@Tratcher
Copy link
Member

Tratcher commented Jul 8, 2017

You don't really need this. We only did it to MemoryCacheOptions so you could easily new up a MemoryCache (e.g. new MemoryCache(new MemoryCacheOptions())), because MemoryCache was something people were likely to create without DI. The same is not true for MemoryDistributedCache, it's only a DI fallback for a real IDistributedCache.

@JunTaoLuo
Copy link
Contributor Author

I noticed this in Session when I was fixing the build, but that was only a test. If we are sure there's no use case for newing up an instance of MemoryDistributedCache then this isn't a big deal.

@JunTaoLuo
Copy link
Contributor Author

Closing, if we need it, then we'll add it.

@JunTaoLuo JunTaoLuo closed this Jul 8, 2017
@JunTaoLuo JunTaoLuo deleted the johluo/better-mdc-options branch July 8, 2017 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants