This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Upgrade to VS 2017 #577
Merged
Upgrade to VS 2017 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoK
reviewed
Jan 4, 2017
| @@ -1,8 +0,0 @@ | |||
| { | |||
| "projects": [ | |||
| "src" | |||
There was a problem hiding this comment.
Unrelated to this PR, is there an equivalent replacement for the global.json hack now to compile a custom repo?
There was a problem hiding this comment.
Not automagically. You have to manually change 'PackageReference' <=> 'ProjectReference'. But the auto project/package interchangability feature is being discussed: dotnet/project-system#199
divega
reviewed
Jan 5, 2017
| public void GeneratesAssemblyAttributeFile() | ||
| { | ||
| if (_solutionRoot == null) | ||
| { | ||
| Assert.True(false, "Could not identify solution root"); | ||
| } | ||
| var target = Path.Combine(_solutionRoot.FullName, "src", "Microsoft.Extensions.Configuration.UserSecrets", "build", "netstandard1.0", "Microsoft.Extensions.Configuration.UserSecrets.targets"); | ||
| Directory.CreateDirectory(Path.Combine(_tempDir, "obj")); | ||
| File.Copy(target, Path.Combine(_tempDir, "obj", "test.csproj.usersecretstest.targets")); // imitates how NuGet will import thsi target |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @divega @HaoK @Eilon