Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Transient and scoped services are not disposed when resolved using a compiled call site #541

Closed
AndriySvyryd opened this issue Jul 4, 2017 · 1 comment
Closed

Transient and scoped services are not disposed when resolved using a compiled call site #541

AndriySvyryd opened this issue Jul 4, 2017 · 1 comment
Labels
3 - Done bug
Milestone
2.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jul 4, 2017 •
edited
Loading

This breaks EF DbContext pooling and could lead to a memory leak.
AndriySvyryd added a commit that referenced this issue Jul 4, 2017
@AndriySvyryd
Fix ImplementationType of ConstructorCallSite
ad1c702 
Fixes #541
This was referenced Jul 4, 2017
Merged
Closed
AndriySvyryd added a commit that referenced this issue Jul 4, 2017
@AndriySvyryd
Fix ImplementationType of ConstructorCallSite and FactoryCallSite
0a7eb15 
Fixes #541
@AndriySvyryd AndriySvyryd changed the title Nested implementations of transient and scoped services are not disposed Transient and scoped services are not disposed when resolved using a compiled call site Jul 4, 2017
@divega
Copy link

divega commented Jul 4, 2017

@Eilon @pakrym Heads up: since it blocks a new EF Core feature, we need it looked at for 2.0.

AndriySvyryd added a commit that referenced this issue Jul 5, 2017
@AndriySvyryd
Fix ImplementationType of ConstructorCallSite and FactoryCallSite
4c7a94c 
Fixes #541
@AndriySvyryd AndriySvyryd added this to the 2.0.0 milestone Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@divega @AndriySvyryd