Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Replace ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder #1007

Closed
JunTaoLuo opened this issue Apr 5, 2017 · 3 comments
Closed

Replace ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder #1007

JunTaoLuo opened this issue Apr 5, 2017 · 3 comments
Assignees
@cesarblum @JunTaoLuo
Labels
3 - Done breaking-change task
Milestone
2.0.0-preview1

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Apr 5, 2017 •
edited
Loading

This method needs to be replaced with ConfigureLogging(Action) after #978. This is still a breaking change since the interface was updated but should not break existing usage of the ConfigureLogging().
@JunTaoLuo JunTaoLuo added this to the 2.0.0 milestone Apr 5, 2017
@JunTaoLuo JunTaoLuo mentioned this issue Apr 10, 2017
Closed
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Apr 10, 2017 •
edited
Loading

Users are expected to use the alternative ConfigureLogging(Action configureLogging) where T : ILoggerFactory. Note that this depends on and may be combined with #1015

@muratg muratg modified the milestones: 2.0.0, 2.0.0-preview1 Apr 13, 2017
@muratg muratg modified the milestones: 2.0.0-preview1, 2.0.0-preview2 Apr 21, 2017
@JunTaoLuo JunTaoLuo mentioned this issue Apr 23, 2017
Merged
@JunTaoLuo JunTaoLuo changed the title Obsolete UseLoggerFactory(ILoggerFactory) and ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder Obsolete ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder Apr 24, 2017
@muratg muratg modified the milestones: 2.0.0-preview1, 2.0.0-preview2 May 2, 2017
@muratg
Copy link

muratg commented May 2, 2017

Adding @CesarBS, and re-triaging to preview1 based on our discussion.

@JunTaoLuo JunTaoLuo changed the title Obsolete ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder Replace ConfigureLogging(Action<ILoggerFactory>) from IWebHostBuilder May 2, 2017
@JunTaoLuo
Copy link
Contributor Author

Will create announcement.

@JunTaoLuo JunTaoLuo mentioned this issue May 11, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cesarblum cesarblum

@JunTaoLuo JunTaoLuo

Labels
3 - Done breaking-change task
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@cesarblum @muratg @JunTaoLuo