This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Replace ConfigureLogging(Action<ILoggerFactory>) with ConfigureLogging(Action<LoggerFactory>) #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2017
davidfowl
reviewed
Apr 23, 2017
| /// </summary> | ||
| /// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to be used.</param> | ||
| /// <returns>The <see cref="IWebHostBuilder"/>.</returns> | ||
| [Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is Microsoft.AspNetCore.Hosting.IwebHostBuilder.UseLoggerFactory(Func<WebHostBuilderContext, ILoggerFactory> createLoggerFactory).")] | ||
| IWebHostBuilder UseLoggerFactory(ILoggerFactory loggerFactory); |
There was a problem hiding this comment.
I'm not sure we need to deprecate this one.
There was a problem hiding this comment.
I believe you are right. @glennc when I originally filed the issue I remember we said we wanted to deprecate both but I don't see why we want to force anyone to use the overload with the context if it's not needed. Can you confirm whether we want to deprecate this?
davidfowl
reviewed
Apr 23, 2017
| /// </summary> | ||
| /// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to be used.</param> | ||
| /// <returns>The <see cref="IWebHostBuilder"/>.</returns> | ||
| [Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is Microsoft.AspNetCore.Hosting.IwebHostBuilder.UseLoggerFactory(Func<WebHostBuilderContext, ILoggerFactory> createLoggerFactory).")] | ||
|
|
JunTaoLuo
force-pushed
the
johluo/obsolete-configure-logging
branch
2 times, most recently
from
cd77f39 to
b5e30f9
Compare
Eilon
approved these changes
Apr 26, 2017
davidfowl
previously approved these changes
Apr 27, 2017
There was a problem hiding this comment.
I don't think we should do this. Instead we should:
- Remove this overload completely instead of deprecating it. It'll only break older libraries that targeted this interface which is mostly nobody.
- Add an extension method
ConfigureLogging(Action<LoggerFactory>)to replace this. It's source compatible with the old overload and upgrading applications will just work.
davidfowl
suggested changes
Apr 27, 2017
There was a problem hiding this comment.
I don't think we should do this. Instead we should:
- Remove this overload completely instead of deprecating it. It'll only break older libraries that targeted this interface which is mostly nobody.
- Add an extension method
ConfigureLogging(Action<LoggerFactory>)to replace this. It's source compatible with the old overload and upgrading applications will just work.
|
@davidfowl the issue has be triaged to preview2. Do you think that is okay or should we pull it back to preview1? |
JunTaoLuo
force-pushed
the
johluo/obsolete-configure-logging
branch
from
b5e30f9 to
2677d21
Compare
JunTaoLuo
force-pushed
the
johluo/obsolete-configure-logging
branch
from
0b53ff1 to
09d58a6
Compare
|
ping @muratg @davidfowl @BrennanConroy @Tratcher since we want to pull this change back to preview1. |
BrennanConroy
approved these changes
May 2, 2017
JunTaoLuo
changed the title
Tratcher
approved these changes
May 2, 2017
| @@ -20,6 +20,7 @@ | |||
| <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="$(AspNetCoreVersion)" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(AspNetCoreVersion)" /> | |||
| <PackageReference Include="Microsoft.Extensions.FileProviders.Abstractions" Version="$(AspNetCoreVersion)" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="$(AspNetCoreVersion)" /> | |||
There was a problem hiding this comment.
Oops this needs to be moved to extensions.
JunTaoLuo
force-pushed
the
johluo/obsolete-configure-logging
branch
from
f4dc329 to
c871a73
Compare
…g(Action<LoggerFactory>) extension
JunTaoLuo
force-pushed
the
johluo/obsolete-configure-logging
branch
from
c871a73 to
3c358e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1007