Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Regression: Not detecting HTTP_PLATFORM_PORT in IIS/Express #470

Closed
Tratcher opened this issue Nov 10, 2015 · 2 comments
Closed

Regression: Not detecting HTTP_PLATFORM_PORT in IIS/Express #470

Tratcher opened this issue Nov 10, 2015 · 2 comments
Assignees
@pakrym
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@Tratcher
Copy link
Member

Regressed by #453
The configuration is now filtering out environment variables that do not begin with "ASPNET_". .AddEnvironmentVariables(prefix: EnvironmentVariablesPrefix).

Either re-work the config to pick up other environment variables, or read HTTP_PLATFORM_PORT directly from the Environment (not recommended as this makes testing more difficult).
@davidfowl
@Tratcher Tratcher added this to the 1.0.0-rc2 milestone Nov 10, 2015
pakrym added a commit that referenced this issue Nov 10, 2015
@pakrym
Fix environment variable loading in hosting #470
2d2865b
pakrym added a commit that referenced this issue Nov 10, 2015
@pakrym
Fix environment variable loading in hosting #470
b2edb0d
@pakrym pakrym closed this as completed Nov 11, 2015
@pakrym pakrym added 3 - Done and removed 1 - Ready labels Nov 11, 2015
@davidfowl
Copy link
Member

Did we add a test?

@pakrym
Copy link
Contributor

pakrym commented Nov 11, 2015

@davidfowl nope, it's environment variable and we cannot test them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pakrym pakrym

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
3 participants
@davidfowl @pakrym @Tratcher