This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
react to removal of PlatformAbstractions #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
approved these changes
Apr 17, 2017
Tratcher
approved these changes
Apr 18, 2017
analogrelay
force-pushed
the
anurse/remove-platform-abstractions
branch
from
538c77a to
99cd97d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ready to merge!
See the test changes for the major impact of this change. If you don't specify either
ConfigureorUseStartup, you're going to get an exception that says "A valid non-empty application name must be provided.". If you work around this withUseSettingyou'll still get an error becauseIStartupisn't present in the container.The only way to get in the situation where the "non-empty application name" message occurs when the app would otherwise start is if you manually insert an
IStartupinto the container. In which case, you should still get this error because we need an application name in order to proceed.