React to dnx dependency injection changes #425
Conversation
|
Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
Next you'll need to update Kestrel and WebListener: https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNet.Server.Kestrel/Program.cs |
| services.TryAdd(ServiceDescriptor.Instance(PlatformServices.Default.AssemblyLoaderContainer)); | ||
| services.TryAdd(ServiceDescriptor.Instance(PlatformServices.Default.LibraryManager)); | ||
| services.TryAdd(ServiceDescriptor.Instance(CompilationServices.Default.LibraryExporter)); | ||
| var serviceProvider = services.BuildServiceProvider(); |
There was a problem hiding this comment.
@davidfowl Since this is all static now can we just move it into a WebHostBuilder constructor? That should also fix TestHost.
There was a problem hiding this comment.
I tried, some tests rely on the fact that some of services are not initialized (ThrowsIfNoApplicationEnvironmentIsRegisteredWithTheProvider) and with ApplicationHost always providing static ApplicationEnvironment it fails
|
Remove the ISP from WebHostBuilder. |
|
@davidfowl done |
|
Looks good! |
|
Is there a reason why we're still waiting on this? MVC is broken |
|
@rynowak no this was aspnet/dnx@6d13295 |
|
@pakrym The appveyor failure is due to the renaming of telemetry and should be fixed now. See if you can restart the test. Even if you can't, I think it's safe to checkin since travis is passing now. This is blocking quite a few things. |
pakrym
force-pushed
the
pakrym/services
branch
from
2f60b2a to
3774b60
Compare
@davidfowl