-
Notifications
You must be signed in to change notification settings - Fork 311
Move Program.Main into WebApplication.Start. #444
Conversation
Perhaps we should keep the Program class, and add the Start methods there? |
|
Call it run instead of start |
Also optionally take in the startup class |
An instance of the startup class rather than just the type? We don't actually support that anywhere in Hosting right now and it won't be trivial to add. We can work on that later. |
@Tratcher no, |
Oh wait you have that 🔹 |
Hmmm hold on |
var tempConfig = tempBuilder.Build(); | ||
var configFilePath = tempConfig[ConfigFileKey] ?? HostingJsonFile; | ||
|
||
var appBasePath = PlatformServices.Default.Application.ApplicationBasePath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to tweak this a bit. Use this logic:
To resolve the application base path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't that done inside of PlatformServices.Default.Application.ApplicationBasePath?
e1d3a35
to
b25e212
Compare
b25e212
to
56256a0
Compare
#430 @davidfowl @DamianEdwards @muratg
This is a really strange class and it's going to confuse anyone that used Katana. It's especially strange that Start never returns. Can we rename Start to Main or Run?