Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Event ids and more logging #447

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Event ids and more logging #447

merged 1 commit into from
Oct 26, 2015

Conversation

victorhurdugaci
Copy link
Contributor

Fixes #363 #374

  • Event ids to logger events
  • Startup/shutdown event ids

Please review @Tratcher @rynowak

@Tratcher
Copy link
Member

LGTM, @rynowak?

logger.LogInformation(
eventId: LoggerEventIds.Shutdown,
message: "Hosting shutdown");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these should be information - these should all be verbose

@victorhurdugaci
Copy link
Contributor Author

Updated

@rynowak
Copy link
Member

rynowak commented Oct 26, 2015

:shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants