Make hosting configuration consistent

[pakrym]

#453

@davidfowl @Tratcher @lodejard @DamianEdwards

[dnfclas]

Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[HaoK]

Perhaps consider making this a POCO and just using ConfigurationBinder to directly bind against config?

[pakrym]

@HaoK can it handle two keys for one property and 1/0 boolean property value?

[Tratcher]

Yeah, this isn't a pattern we use anywhere else.

[HaoK]

You could just have a string property that maps to the key in config, and then expose the current logic just like you do now.

public string DetailedErrors { get; set; }

public bool IsDetailed { get { <same logic as you have> }

[pakrym]

🆙 📅

[Tratcher]

no params needed

[pakrym]

🆙 📅

[davidfowl]

nit:can you move this to the bottom

[davidfowl]

Nuke those tests that change the env and

[HaoK]

So if you wanted to use the config binder, it would look something more like this, the only weirdness is with the Environment/DetailedErrors properties which need a method to add the logic.

public class WebHostOptions {
    public string App { get; set; }
    public string Server {get; set; }
   public string WebRoot {get; set; }
   public string DetailedErrors {get; set; }
   public string Environment {get; set; }
   public string Env {get; set; }

   public bool ShowDetailedErrors { get {
      return string.Equals("true", DetailedErrors)
                || string.Equals("1", DetailedErrors) ;
   } }

   public string ResolveEnvironment() {
      return Environment ?? Env;
   }
}

To get it out of config assuming its at the root level:
   config.Get<WebHostOptions>();

[HaoK]

The upside, is you can nuke the keys (the property names for the POCO are automatically the keys. It would just work except for the weirdness around DetailedErrors and supporting the old Env key...

[davidfowl]

@pakrym make an announcement