Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Make contentRootPath error give failed path #706

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

ryanbrandenburg
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg commented Apr 15, 2016

Include the content root that doesn't exist in the error message for a missing content root to make debugging easier.

Fixes #707.

@dnfclas
Copy link

dnfclas commented Apr 15, 2016

Hi @ryanbrandenburg, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Tratcher
Copy link
Member

:shipit:

@Tratcher
Copy link
Member

#707

@ryanbrandenburg
Copy link
Contributor Author

Ha, I didn't even see that bug @Tratcher, I just got annoyed at it.

@Tratcher
Copy link
Member

Check the timestamps. you fixed it before there was a bug.

@ryanbrandenburg ryanbrandenburg merged commit 6a57ec1 into dev Apr 15, 2016
@pranavkm
Copy link
Contributor

Can we fix this in release? Seems like a poor user experience not having this parameter

@ryanbrandenburg
Copy link
Contributor Author

I'll ask @Eilon.

@JunTaoLuo JunTaoLuo deleted the rybrande/InformativeContentRoot branch May 19, 2017 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants