This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Create IHostingEnvironment. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| public class HostingEnvironment : IHostingEnvironment | ||
| { | ||
| public HostingEnvironment() |
There was a problem hiding this comment.
Needed? (Don't really care either way.)
|
Updated. |
1 similar comment
|
Updated. |
| try | ||
| { | ||
| var config = new Configuration(); | ||
| config.AddJsonFile("project.json"); |
There was a problem hiding this comment.
Path.Combine(applicationBasePath, "project.json")
|
Updated. |
| var env = serviceProvider.GetService<IApplicationEnvironment>(); | ||
| if (env == null) | ||
| var appEnv = serviceProvider.GetService<IApplicationEnvironment>(); | ||
| if (appEnv == null) |
There was a problem hiding this comment.
Wondering - can the service be null? I thought DI throws if it's not registered. And that you have to ask for IEnumerable<T> to get 0 or more instances. Do we have a unit test for these scenarios?
There was a problem hiding this comment.
You're right, DI does throw now, I'll remove this old code.
|
|
|
After those changes |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#71