This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Removing DefaultHostingConfiguration #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,8 +28,10 @@ public void Configure(IApplicationBuilder app) | |||
| // Entry point for the application. | |||
| public static void Main(string[] args) | |||
| { | |||
| var config = new ConfigurationBuilder().AddCommandLine(args).Build(); | |||
There was a problem hiding this comment.
Remove config from this sample.
JunTaoLuo
force-pushed
the
johluo/remove-default-config
branch
from
99e1681 to
109c28f
Compare
|
Side note: The IISIntegration changes need to be checked in first, and they don't rely on any of these changes. |
| var config = new ConfigurationBuilder() | ||
| .AddCommandLine(args) | ||
| .AddEnvironmentVariables(prefix: WebHostDefaults.EnvironmentVariablesPrefix) | ||
| .AddJsonFile(WebHostDefaults.HostingJsonFile, optional: true) |
There was a problem hiding this comment.
Remove the WebHostDefaults.HostingJsonFile constant, it's no longer used in src.
I'm tempted to remove WebHostDefaults.EnvironmentVariablesPrefix as well, as it's only used once in src.
JunTaoLuo
force-pushed
the
johluo/remove-default-config
branch
2 times, most recently
from
587c746 to
79a7143
Compare
| @@ -28,7 +28,6 @@ public void Configure(IApplicationBuilder app) | |||
| public static void Main(string[] args) | |||
| { | |||
| var host = new WebHostBuilder() | |||
| .UseDefaultHostingConfiguration(args) | |||
| .UseStartup<StartupHelloWorld>() | |||
There was a problem hiding this comment.
good catch, here and in StartupExternallyControlled.
|
|
…ostingConfiguration
JunTaoLuo
force-pushed
the
johluo/remove-default-config
branch
from
79a7143 to
e505ecb
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue addresses #727, #700 and render #693 not applicable
As discussed offline with @davidfowl @Tratcher , we are removing default hosting configurations and the user is expected to construct their own configurations. The only exception is that we fallback to environment variables for the
Environmentoption. I'll make an update to IISIntegration in a later PR to see what the changes there look like.We will also need to update all of our samples again.