This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Remove UseServer(string) overload #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,13 +71,12 @@ public void CanStartWithOldServerConfig() | |||
| { | |||
There was a problem hiding this comment.
These tests were for the feature you removed, remove them.
|
Some usages to replace before merging this: |
|
Looks good to me after you remove the redundant tests. I think we still use this in some places for testing. We'll need to update them. |
- Removed the overload that takes a string because it's broken #731
davidfowl
force-pushed
the
davidfowl/remove-use-server
branch
from
626cb55 to
41b4e60
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UseServer overloads #731
/cc @Tratcher @JunTaoLuo @DavidObando (to make sure the stress repository doesn't use this thing)