Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Change SignInManager's private helper methods to protected. #939

Closed
RoySalisbury opened this issue Aug 19, 2016 · 1 comment
Closed

Change SignInManager's private helper methods to protected. #939

RoySalisbury opened this issue Aug 19, 2016 · 1 comment

Comments

@RoySalisbury
Copy link

I have to implement a "PinSignInAsync" method on my SignInManager. This will basically be (almost) exactly like the PasswordSignInAsync" method, but will be calling a new "UserManager.CheckPinAsync" method and does not have to deal with TwoFactor code.

To implement this I looked at the existing password method, and there are 4 private methods that it uses. If these were protected, then I could use them in my own derived class so code is reused and not duplicated.

    private async Task<bool> IsLockedOut(TUser user)
    private async Task<SignInResult> LockedOut(TUser user)
    private async Task<SignInResult> PreSignInCheck(TUser user)
    private Task ResetLockout(TUser user)

I would also suggest reviewing the other private and internal methods/classes to see if the would benefit from being protected/protected internal.

@HaoK
Copy link
Member

HaoK commented Sep 26, 2016

dbec1c6

@HaoK HaoK closed this as completed Sep 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants