This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Expose more for extensibility #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divega
reviewed
Sep 23, 2016
|
These used to be all public and the unit tests tweak the Managers this way still. They were made internal when we switched to DI to initialize in 3.0.
|
|
Thanks for the information. One more question: what criteria are you using to decide what to make virtual and what not? |
|
I only made the protected methods virtual since there was no harm in letting them tweak those behaviors. The properties are get/set, so those should be fine non virtual |
divega
approved these changes
Sep 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939
#969
@divega