-
Notifications
You must be signed in to change notification settings - Fork 865
Add Microsoft.Extensions.Identity.Core + Stores #1188
Conversation
@ajcvickers updated PR with what we discussed (keeping the old AspNetCore namespaces). There is still one minor breaking change with the POCOs moving from Microsoft.AspNetCore.Identity.EntityFrameworkCore => Microsoft.AspNetCore.Identity, this isn't as big of a deal since most references are already including both, but there will be a few places in the models that will need to change the using. |
@HaoK is there a particular reason why the EF Core stores have to depend on |
@PinpointTownes no particular reason, that's a good idea, I can move the builder to Core and switch the stores to depend on only on the extensions, so effectively we can rename it to Microsoft.Extensions.Identity.EntityFrameworkCore, something we can consider post preview2 |
I'll file an issue so we don't forget |
First cut at splitting Identity into:
This is a big change so figured we should get the ball rolling with the PR, and can go over this in person next triage. The biggest breaking change out of this is moving to a different namespace (Microsoft.Extensions) which requires new usings.
Microsoft.Extensions.Identity.Core contains:
Microsoft.AspNetCore.Identity contains:
Microsoft.Extensions.Identity.Stores contains:
Microsoft.AspNetCore.Identity.EntityFrameworkStores will contain[as of next iteration]:
Next steps: need to look into refactoring some of the sign in functionality like lockout back into UserManager.
@divega @ajcvickers @blowdart
Fixes: #651 and #883