This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
Move POCO to core #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move IdentityUser pocos to core so store implementations can share/reuse code - TBD Entity changes to use poco correctly (No DateTimeOffset support, and concrete navigation types)
Blocking EF fixes are in, all tests now pass
100% coverage for Identity.Entity
Tests for SetRole/UserName
| @@ -6,12 +6,12 @@ namespace Microsoft.AspNet.Identity.Entity | |||
| /// <summary> | |||
| /// Represents a Role entity | |||
| /// </summary> | |||
| public class IdentityRole : IdentityRole<string, IdentityUserRole> | |||
| public class EntityRole : EntityRole<string, IdentityUserRole> | |||
There was a problem hiding this comment.
Is the rename temporary until we consolidate?
There was a problem hiding this comment.
Got what you are doing. Sounds good. I just hope we can get rid of these 😄
There was a problem hiding this comment.
Yup I will try to get rid of these as soon as I can (but I'm going to wait until the Sql version is ready to make sure there are no issues there)
|
Besides the suggestion to add a few TODOs, this looks |
to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share/reuse code
and concrete navigation types)