This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Honor PreferHostingUrls #1655
Merged
Honor PreferHostingUrls #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easier to review with https://github.com/aspnet/KestrelHttpServer/pull/1655/files?w=1 |
|
This is going to conflict with my Start/Stop PR that I'm merging tomorrow. |
|
Go ahead and merge your changes for startasync/stopasync. I'll rework this PR. |
natemcmaster
approved these changes
Apr 12, 2017
| } | ||
|
|
||
| [ConditionalFact] | ||
| [PortSupportedCondition(5000)] |
There was a problem hiding this comment.
The test uses 5001, not 5000.
JunTaoLuo
force-pushed
the
johluo/use-hosting-urls
branch
from
840ddd2 to
2398330
Compare
halter73
approved these changes
Apr 13, 2017
| if (hasListenOptions) | ||
| { | ||
| var joined = string.Join(", ", _serverAddresses.Addresses); | ||
| _logger.LogWarning($"Overriding endpoints defined in UseKestrel() since {nameof(IServerAddressesFeature.PreferHostingUrls)} is set to true. Binding to address(es) '{joined}' instead."); |
There was a problem hiding this comment.
This is something that we expect to happen when PreferHostingUrls is set to true. Is this worth a warning? Or should we log as info?
There was a problem hiding this comment.
I'll log as info.
|
Rebase ofc. |
JunTaoLuo
force-pushed
the
johluo/use-hosting-urls
branch
from
88f7795 to
08f9056
Compare
JunTaoLuo
force-pushed
the
johluo/use-hosting-urls
branch
from
6b676d8 to
0723d46
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1575. Alternative to #1639
We want to override the endpoints configured in the listen options when PreferHostingUrls is set to true with the addresses in the IServerAddressesFeature if it's not empty.
Will squash with a meaningful commit message once ready to merge.